[
https://issues.apache.org/jira/browse/GEODE-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100744#comment-16100744
]
ASF GitHub Bot commented on GEODE-2886:
---------------------------------------
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r129418949
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
---
@@ -290,6 +295,24 @@ public void queryJsonObject() throws Exception {
}
@Test()
+ public void testWaitUntilFlushedForException() throws Exception {
+ Map<String, Analyzer> fields = new HashMap<String, Analyzer>();
+ fields.put("name", null);
+ fields.put("lastName", null);
+ fields.put("address", null);
+
luceneService.createIndexFactory().setFields(fields).create(INDEX_NAME,
REGION_NAME);
+ Region region =
cache.createRegionFactory(RegionShortcut.PARTITION).create(REGION_NAME);
+ final LuceneIndex index = luceneService.getIndex(INDEX_NAME,
REGION_NAME);
+
+ // This is to send IllegalStateException from WaitUntilFlushedFunction
+ String nonCreatedIndex = "index2";
+
+ boolean b =
+ luceneService.waitUntilFlushed(nonCreatedIndex, REGION_NAME,
60000, TimeUnit.MILLISECONDS);
+ assertFalse(b);
--- End diff --
@ameybarve15
I was under the assumption that the client currently is being passed the
IllegalArgumentException and instead we would just throw the
IllegalStateException and piggy back off of how FunctionExecution handles
exceptions. When a function fails during function execution, I would think an
exception is passed back to the user?
> The WaitUntilFlushedFunction throws an IllegalArgumentException instead of an
> IllegalStateException
> ---------------------------------------------------------------------------------------------------
>
> Key: GEODE-2886
> URL: https://issues.apache.org/jira/browse/GEODE-2886
> Project: Geode
> Issue Type: Bug
> Components: lucene
> Reporter: Barry Oglesby
> Assignee: Amey Barve
>
> When the AEQ doesn't exist, the WaitUntilFlushedFunction throws an
> IllegalArgumentException like:
> {noformat}
> Caused by: java.lang.IllegalArgumentException: The AEQ does not exist for the
> index xxx region /yyy
> at
> org.apache.geode.cache.lucene.internal.distributed.WaitUntilFlushedFunction.execute(WaitUntilFlushedFunction.java:89)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.executeFunctionLocally(AbstractExecution.java:333)
> {noformat}
> The arguments are actually fine so should it instead throw an
> IllegalStateException?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
