[
https://issues.apache.org/jira/browse/GEODE-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105329#comment-16105329
]
ASF GitHub Bot commented on GEODE-3254:
---------------------------------------
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/665
GEODE-3254: Refactoring ConfigCommands and ConfigCommandsDUnitTest
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3254)
`ConfigCommands.java` was a large class that contained multiple commands.
Each command was refactored into a separate class.
`ConfigCommandsDUnitTest.java` was also split into separate test classes.
- [x] JIRA ticket referenced
- [x] PR rebased
- [x] Single squashed commit
- [x] Builds cleanly
- [x] Tests updated
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode GEODE-3254
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/665.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #665
----
commit 11c88b725eee219e5ec90e546d6e6fa1709a1b16
Author: YehEmily <emilyyeh1...@gmail.com>
Date: 2017-07-26T18:07:09Z
GEODE-3254: Refactoring ConfigCommands and ConfigCommandsDUnitTest
----
> Refactor ConfigCommands
> -----------------------
>
> Key: GEODE-3254
> URL: https://issues.apache.org/jira/browse/GEODE-3254
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> {{ConfigCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
