[ 
https://issues.apache.org/jira/browse/GEODE-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Anuta updated GEODE-3184:
-------------------------------
    Description: 
Would be good to review  the code base and make sure methods are properly 
organized.

Also, the previous session replication testing is still in place in the 
extensions folder. This needs to be reviewed and any tests not covered by cargo 
should be transferred over into the new cargo replication testing. An example 
of something within this that needs to be cleaned up would be QueryCommand and 
CommandServlet classes, which are both in the extensions/geode-modules and 
extensions/session-testing-war projects. the QueryCommand and Command Servlet 
class within the extensions/geode-modules project could be removed if the 
previous session tests were all ported to cargo and then removed.

  was:
Some of the methods that are class specific (ex. 
getServerLifeCycleListenerClass) may be located in a super level class, instead 
of in a specific class as would be expected. Would be good to review  the code 
base and make sure methods are properly organized.

Also, the previous session replication testing is still in place in the 
extensions folder. This needs to be reviewed and any tests not covered by cargo 
should be transferred over into the new cargo replication testing. An example 
of something within this that needs to be cleaned up would be QueryCommand and 
CommandServlet classes, which are both in the extensions/geode-modules and 
extensions/session-testing-war projects. the QueryCommand and Command Servlet 
class within the extensions/geode-modules project could be removed if the 
previous session tests were all ported to cargo and then removed.


> Clean up session replication testing
> ------------------------------------
>
>                 Key: GEODE-3184
>                 URL: https://issues.apache.org/jira/browse/GEODE-3184
>             Project: Geode
>          Issue Type: Improvement
>          Components: http session
>            Reporter: David Anuta
>
> Would be good to review  the code base and make sure methods are properly 
> organized.
> Also, the previous session replication testing is still in place in the 
> extensions folder. This needs to be reviewed and any tests not covered by 
> cargo should be transferred over into the new cargo replication testing. An 
> example of something within this that needs to be cleaned up would be 
> QueryCommand and CommandServlet classes, which are both in the 
> extensions/geode-modules and extensions/session-testing-war projects. the 
> QueryCommand and Command Servlet class within the extensions/geode-modules 
> project could be removed if the previous session tests were all ported to 
> cargo and then removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to