[
https://issues.apache.org/jira/browse/GEODE-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110259#comment-16110259
]
ASF GitHub Bot commented on GEODE-3321:
---------------------------------------
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/676#discussion_r130781436
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandlerJUnitTest.java
---
@@ -95,8 +97,8 @@ public void
processReturnsUnsucessfulResponseForInvalidRegion()
operationHandler.process(serializationServiceStub, removeRequest,
cacheStub);
assertTrue(result instanceof Failure);
- org.junit.Assert.assertThat(result.getErrorMessage().getMessage(),
- CoreMatchers.containsString("Region"));
+ assertEquals(ProtocolErrorCode.REGION_NOT_FOUND.codeValue,
--- End diff --
YES. I like these kinds of tests much better.
> Error Codes Specification for all operations
> --------------------------------------------
>
> Key: GEODE-3321
> URL: https://issues.apache.org/jira/browse/GEODE-3321
> Project: Geode
> Issue Type: Sub-task
> Components: client/server
> Reporter: Brian Baynes
>
> As a developer using the new protocol, I need to know what error codes to
> expect from the server and what they mean.
> Delineate the possible error codes for each operation, documenting each error
> code, when it will occur, and what message will be associated with it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
