[
https://issues.apache.org/jira/browse/GEODE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111372#comment-16111372
]
ASF GitHub Bot commented on GEODE-3384:
---------------------------------------
GitHub user nabarunnag opened a pull request:
https://github.com/apache/geode/pull/678
GEODE-3384: Javadoc change for PageableLuceneQueryResults
* Javadocs now mention that PageableLuceneQueryResults are serializable
and can be sent to other members
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3384
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/678.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #678
----
commit 5eddfc9ac1b70757e7dedf9c4e8cb9d0c3078614
Author: nabarun <[email protected]>
Date: 2017-08-02T17:26:07Z
GEODE-3384: Javadoc change for PageabelLuceneQueryResults
* Javadocs now mention that PageableLuceneQueryResults are serializable
and can be sent to other members
----
> Incorrect java doc for PageableLuceneQueryResults
> -------------------------------------------------
>
> Key: GEODE-3384
> URL: https://issues.apache.org/jira/browse/GEODE-3384
> Project: Geode
> Issue Type: Bug
> Components: lucene
> Reporter: nabarun
> Assignee: nabarun
>
> Javadocs for PageableLuceneQueryResults mention that
> {noformat}
> * Each page is fetched individually from the server, so {@link
> PageableLuceneQueryResults} cannot
> * be serialized and sent to other members.
> {noformat}
> but now this interface is serializable, this change must be reflected in the
> javadoc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
