[
https://issues.apache.org/jira/browse/GEODE-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111651#comment-16111651
]
ASF GitHub Bot commented on GEODE-3230:
---------------------------------------
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/651#discussion_r130982335
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
---
@@ -633,8 +631,8 @@ public DataCommandResult put(String key, String value,
boolean putIfAbsent, Stri
try {
keyObject = getClassObject(key, keyClass);
} catch (ClassNotFoundException e) {
- return DataCommandResult.createPutResult(key, null, null,
- "ClassNotFoundException " + keyClass, false);
+ return DataCommandResult.createPutResult(key, null,
e.getException(),
--- End diff --
I don't understand the context of this change - the message was
"ClassNotFound" but now it's "key not found" with a key class?
> Delete unused commands in CliStrings
> ------------------------------------
>
> Key: GEODE-3230
> URL: https://issues.apache.org/jira/browse/GEODE-3230
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> There are a lot of commands in {{CliStrings}} that aren't used. For example,
> {{start manager}} has a whole set of associated commands -
> {{START_MANAGER__MEMBERNAME}}, {{START_MANAGER__DIR}},
> {{START_MANAGER__CLASSPATH}}, etc.) that don't seem to be used anywhere.
> These commands should be deleted to clean up the code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
