[ 
https://issues.apache.org/jira/browse/GEODE-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111768#comment-16111768
 ] 

ASF GitHub Bot commented on GEODE-3038:
---------------------------------------

Github user dschneider-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/677#discussion_r131003885
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
---
    @@ -1208,6 +1208,9 @@ private void initialize() {
               this.system.getConfig());
           initializeDeclarativeCache();
           completedCacheXml = true;
    +    } catch (CacheXmlException e) {
    --- End diff --
    
    It looks like a number of exceptions can be thrown from 
initializeDeclarativeCache.
    Would it be better to catch, log, and rethrow RuntimeException instead of 
CacheXmlException?


> A server process shuts down quietly when path to cache.xml is incorrect
> -----------------------------------------------------------------------
>
>                 Key: GEODE-3038
>                 URL: https://issues.apache.org/jira/browse/GEODE-3038
>             Project: Geode
>          Issue Type: Bug
>          Components: configuration
>            Reporter: Anton Mironenko
>            Assignee: Kirk Lund
>            Priority: Minor
>
> Geode version: 1.1.1, 1.3.0 (latest develop snapshot)
> If I start a server with incorrect path to Server.xml, it shuts down quietly 
> without any message in the log. 
> An expected behavior would be the error message "Server.xml not found in the 
> path [...], shutting down"
> Here are the steps to reproduce, please use GEODE-3003 for zip files.
> Test preparation:
> ---------------------
> Here are two attached zip files - "geode-host1.zip" and "geode-host2.zip"
> 1) unzip "geode-host1.zip" into some folder on your first host
> 2) in start-locator.sh change the IPs of locators to the values of your host1 
> and host2
> "--locators=10.50.3.38[20236],10.50.3.14[20236]"
> 3) in start-server.sh
> "locators=10.50.3.38[20236],10.50.3.14[20236]" change the IPs of locators to 
> the values of your host1 and host2
> 4) do the bullets 1)-4) for host2, the folder where you unzip the file should 
> be the same as on the first host
> Test running:
> ---------------
> 0) change start-server.sh so that the path to Server.xml is wrong
> cache-xml-file=$SERVERXML_DIR/Server.xml
> ->
> cache-xml-file=$SERVERXML_DIR/Server_.xml
> 1) run ./start-locator.sh on host1
> 2) after some pause run ./start-server
> 3) observe the server started and immediately stopped,
> 4) observe in the server logs, server1/cacheserver.log:
> [info 2017/06/06 18:32:05.141 MSK host1-server-1 <main> tid=0x1] Received 
> cluster configuration from the locator
> [info 2017/06/06 18:32:05.141 MSK host1-server-1 <main> tid=0x1] 
>   ***************************************************************
>   Configuration for  'cluster'
>   
>   Jar files to deployed
> [info 2017/06/06 18:32:05.141 MSK host1-server-1 <main> tid=0x1] Requesting 
> cluster configuration
> [info 2017/06/06 18:32:05.143 MSK host1-server-1 <main> tid=0x1] Got response 
> with jars: 
> [info 2017/06/06 18:32:05.209 MSK host1-server-1 <main> tid=0x1] Initializing 
> region _monitoringRegion_10.50.3.38<v1>1025
> [info 2017/06/06 18:32:05.222 MSK host1-server-1 <main> tid=0x1] Region 
> _monitoringRegion_10.50.3.38<v1>1025 requesting initial image from 
> 10.50.3.38(host1-locator-0-20236:27511:locator)<ec><v0>:1024
> [info 2017/06/06 18:32:05.227 MSK host1-server-1 <main> tid=0x1] 
> _monitoringRegion_10.50.3.38<v1>1025 is done getting image from 
> 10.50.3.38(host1-locator-0-20236:27511:locator)<ec><v0>:1024. isDeltaGII is 
> false
> [info 2017/06/06 18:32:05.228 MSK host1-server-1 <main> tid=0x1] 
> Initialization of region _monitoringRegion_10.50.3.38<v1>1025 completed
> [info 2017/06/06 18:32:05.812 MSK host1-server-1 <main> tid=0x1] 
> GemFireCache[id = 2117642238; isClosing = true; isShutDownAll = false; 
> created = Tue Jun 06 18:32:05 MSK 2017; server = false; copyOnRead = false; 
> lockLease = 120; lockTimeout = 60]: Now closing.
> [info 2017/06/06 18:32:05.855 MSK host1-server-1 <main> tid=0x1] Shutting 
> down DistributionManager 10.50.3.38(host1-server-1:27773)<v1>:1025. 
> [info 2017/06/06 18:32:05.961 MSK host1-server-1 <main> tid=0x1] Now closing 
> distribution for 10.50.3.38(host1-server-1:27773)<v1>:1025
> [info 2017/06/06 18:32:05.962 MSK host1-server-1 <main> tid=0x1] Stopping 
> membership services
> [info 2017/06/06 18:32:05.964 MSK host1-server-1 <Geode Failure Detection 
> Server thread 0> tid=0x1d] GMSHealthMonitor server thread exiting
> [info 2017/06/06 18:32:05.964 MSK host1-server-1 <main> tid=0x1] 
> GMSHealthMonitor server socket is closed in stopServices().
> [info 2017/06/06 18:32:05.968 MSK host1-server-1 <main> tid=0x1] 
> GMSHealthMonitor serverSocketExecutor is terminated
> [info 2017/06/06 18:32:05.974 MSK host1-server-1 <main> tid=0x1] 
> DistributionManager stopped in 119ms.
> [info 2017/06/06 18:32:05.974 MSK host1-server-1 <main> tid=0x1] Marking 
> DistributionManager 10.50.3.38(host1-server-1:27773)<v1>:1025 as closed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to