[ 
https://issues.apache.org/jira/browse/GEODE-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114714#comment-16114714
 ] 

ASF GitHub Bot commented on GEODE-3266:
---------------------------------------

GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/684

    GEODE-3266: Refactoring PDXCommands

    [View the JIRA ticket 
here.](https://issues.apache.org/jira/browse/GEODE-3266)
    
    
    - [x] JIRA ticket referenced
    
    - [x] PR rebased
    
    - [x] Single, squashed commit
    
    - [x] `gradlew build` runs cleanly
    
    - [ ] Associated tests to be updated with 
[GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3266

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/684.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #684
    
----
commit de75047552a794332f10773c4d9bfdb4f3015575
Author: YehEmily <[email protected]>
Date:   2017-08-04T17:47:48Z

    GEODE-3266: Refactoring PDXCommands

----


> Refactor PDXCommands
> --------------------
>
>                 Key: GEODE-3266
>                 URL: https://issues.apache.org/jira/browse/GEODE-3266
>             Project: Geode
>          Issue Type: Sub-task
>          Components: gfsh
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
>
> {{PDXCommands.java}} is a large class that contains multiple commands. Each 
> command should be refactored into a separate class, and the methods shared by 
> the commands should be refactored into a new and appropriately named class of 
> their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to