[ 
https://issues.apache.org/jira/browse/GEODE-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117490#comment-16117490
 ] 

ASF GitHub Bot commented on GEODE-3268:
---------------------------------------

Github user PurelyApplied commented on a diff in the pull request:

    https://github.com/apache/geode/pull/693#discussion_r131775100
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/RegionCommandsController.java
 ---
    @@ -26,11 +26,12 @@
     import org.springframework.web.context.request.WebRequest;
     
     /**
    - * The RegionCommands class implements GemFire Management REST API web 
service endpoints for the
    - * Gfsh Region Commands.
    + * The ListRegionCommand and DescribeRegionCommand classes implement 
GemFire Management REST API web
    --- End diff --
    
    My eternal nitpick: make sure you optimize / reorder imports in the files 
you touch, please.


> Refactor RegionCommands
> -----------------------
>
>                 Key: GEODE-3268
>                 URL: https://issues.apache.org/jira/browse/GEODE-3268
>             Project: Geode
>          Issue Type: Sub-task
>          Components: gfsh
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
>
> {{RegionCommands.java}} is a large class that contains multiple commands. 
> Each command should be refactored into a separate class, and the methods 
> shared by the commands should be refactored into a new and appropriately 
> named class of their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to