ASF GitHub Bot commented on GEODE-3337:

GitHub user YehEmily opened a pull request:


    GEODE-3337: Refactoring LauncherLifecycleCommandsDUnitTest

    [View the JIRA ticket 
    `LauncherLifecycleCommandsDUnitTest` was a huge test class that tested 
multiple commands, in addition to using the deprecated `CliCommandsTestBase`. 
These tests have been refactored to use more up-to-date test rules and also 
separated into test classes based on the command that they test.
    Some tests in the original `LauncherLifecycleCommandsDUnitTest` seemed to 
be unnecessary or redundant (for example, `StatusLocatorRealGfshTest` already 
tested some of the tests in `LauncherLifecycleCommandsDUnitTest`) so these were 
    *Testing Status: Precheckin in progress*
    - [ ] JIRA ticket
    - [ ] Rebased
    - [ ] Single commit
    - [ ] `gradlew build` runs cleanly
    - [ ] Tests updated

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3337

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #701
commit c4cdc531c41502d6a162715e324380b66d95794e
Author: YehEmily <emilyyeh1...@gmail.com>
Date:   2017-08-09T17:45:43Z

    GEODE-3337: Refactoring LauncherLifecycleCommandsDUnitTest


> Refactor LauncherLifecycleCommandsDUnitTest to use test rules
> -------------------------------------------------------------
>                 Key: GEODE-3337
>                 URL: https://issues.apache.org/jira/browse/GEODE-3337
>             Project: Geode
>          Issue Type: Sub-task
>          Components: tests
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
> {{LauncherLifecycleCommandsDUnitTest}} is using {{CliCommandTestBase}}, which 
> is a deprecated class. It should be refactored to use more current test rules.

This message was sent by Atlassian JIRA

Reply via email to