[ https://issues.apache.org/jira/browse/GEODE-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122532#comment-16122532 ]
ASF GitHub Bot commented on GEODE-3386: --------------------------------------- Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/700#discussion_r132591701 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java --- @@ -28,6 +28,8 @@ import org.apache.geode.serialization.SerializationService; import org.apache.geode.serialization.exception.UnsupportedEncodingTypeException; import org.apache.geode.serialization.registry.exception.CodecNotRegisteredForTypeException; + +import com.fasterxml.jackson.databind.introspect.TypeResolutionContext; --- End diff -- I don't see how this new import is being used? > Create Error type for KeyedErrorResponse and ErrorResponse > ---------------------------------------------------------- > > Key: GEODE-3386 > URL: https://issues.apache.org/jira/browse/GEODE-3386 > Project: Geode > Issue Type: Sub-task > Components: client/server > Reporter: Galen O'Sullivan > > For logical separation of the new client API, it will be better to have an > Error that is contained by ErrorResponse, rather than having > KeyedErrorResponse contain an ErrorResponse. > In pseudo-protobuf, > {code} > PutAllResponse { > repeated Entry successes = 1, > repeated KeyedErrorResponse errors = 2, > } > KeyedErrorResponse { > Key, > ErrorResponse > } > ErrorResponse { > string > } > {code} > instead, > {code} > KeyedErrorResponse { > Key, > Error, > } > {code} > and > {code} > ErrorResponse { > Error > } > Error { > string > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)