[
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131391#comment-16131391
]
ASF GitHub Bot commented on GEODE-3434:
---------------------------------------
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133843558
--- Diff:
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
---
@@ -586,6 +610,20 @@ public int getSizeInBytes() {
return serializedAttributes;
}
+ protected ConcurrentMap getAttributes() {
+ try {
+ Field field = getAttributesFieldObject();
+ field.setAccessible(true);
+ Map oldMap = (Map) field.get(this);
+ ConcurrentMap newMap = new ConcurrentHashMap();
--- End diff --
I think you are correct, I believe we wrapped it incase somehow it was not
a concurrent hash map but I guess that was being overly cautious. I'll change
them all to map
> Allow the modules to be interoperable with current and older versions of
> tomcat 7
> ----------------------------------------------------------------------------------
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
> Issue Type: Bug
> Components: http session
> Reporter: Jason Huynh
> Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the
> necessary changes in geode session modules), but that does not allow our
> session modules to work with older versions of tomcat 7. We can probably
> modify the classes to allow use with of the session module jars across
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to
> allow backwards compatibility between a geode server and a session module jar
> from a previous release.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
