[
https://issues.apache.org/jira/browse/GEODE-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133836#comment-16133836
]
ASF GitHub Bot commented on GEODE-3469:
---------------------------------------
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/724#discussion_r134077082
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePid.java
---
@@ -30,37 +30,88 @@
*/
public class AvailablePid {
- static final int LOWER_BOUND = 1;
- static final int UPPER_BOUND = 64000;
+ static final int DEFAULT_LOWER_BOUND = 1;
+ static final int DEFAULT_UPPER_BOUND = 64000;
static final int DEFAULT_TIMEOUT_MILLIS = 60 * 1000;
+ private final int lowerBound;
+ private final int upperBound;
private final Random random;
private final int timeoutMillis;
/**
- * Construct with no seed and default timeout of 1 minute.
+ * Construct with:
+ * <ul>
+ * <li>default {@link Bounds} of {@link #DEFAULT_LOWER_BOUND}
(inclusive) and
+ * {@link #DEFAULT_UPPER_BOUND} (inclusive)
+ * <li>Random with no see
--- End diff --
I no see your point ;)
> LocatorLauncherLocalFileIntegrationTest.usesLocatorPortAsDefaultPort fails
> intermittently with IllegalArgumentException: Invalid pid '0' specified
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-3469
> URL: https://issues.apache.org/jira/browse/GEODE-3469
> Project: Geode
> Issue Type: Bug
> Components: gfsh, tests
> Reporter: Kirk Lund
> Assignee: Kirk Lund
>
> {noformat}
> org.apache.geode.distributed.LocatorLauncherLocalFileIntegrationTest >
> usesLocatorPortAsDefaultPort FAILED
> java.lang.IllegalArgumentException: Invalid pid '0' specified
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
