[
https://issues.apache.org/jira/browse/GEODE-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135332#comment-16135332
]
ASF GitHub Bot commented on GEODE-3474:
---------------------------------------
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/726
GEODE-3474: protobuf auth with ExampleSecurityManager
It looks like we were using the wrong constants for the username and
password strings; ExampleSecurityManager uses some defined constants that look
more canonical.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [n/a] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/galen-pivotal/geode feature/GEODE-3474
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/726.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #726
----
commit 7db0cad2d5f299c905e0a6f917c2ca4671bd2268
Author: Galen O'Sullivan <[email protected]>
Date: 2017-08-21T15:29:54Z
GEODE-3474: protobuf auth with ExampleSecurityManager
----
> ProtobufSimpleAuthenticator is incompatible with ExampleSecurityManager
> -----------------------------------------------------------------------
>
> Key: GEODE-3474
> URL: https://issues.apache.org/jira/browse/GEODE-3474
> Project: Geode
> Issue Type: Sub-task
> Components: messaging
> Reporter: Galen O'Sullivan
> Assignee: Galen O'Sullivan
>
> {{ProtobufSimpleAuthenticator}} uses the property names "username" and
> password" to provide credentials, but {{ExampleSecurityManager}} uses
> "security-username" and "security-password". These are defined as
> {{ResourceConstants.USER_NAME}} and {{ResourceConstants.PASSWORD}} and
> therefore probably the correct values to use.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
