[ 
https://issues.apache.org/jira/browse/GEODE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140926#comment-16140926
 ] 

ASF GitHub Bot commented on GEODE-3513:
---------------------------------------

Github user upthewaterspout commented on a diff in the pull request:

    https://github.com/apache/geode/pull/740#discussion_r135150926
  
    --- Diff: 
extensions/session-testing-war/src/main/java/org/apache/geode/modules/session/SessionCountingListener.java
 ---
    @@ -12,28 +12,35 @@
      * or implied. See the License for the specific language governing 
permissions and limitations under
      * the License.
      */
    +package org.apache.geode.modules.session;
     
    -package org.apache.geode.modules.session.internal.filter;
    -
    -import org.apache.geode.modules.session.filter.SessionCachingFilter;
    -
    -import javax.servlet.http.HttpSession;
    +import java.util.concurrent.atomic.AtomicInteger;
     import javax.servlet.http.HttpSessionEvent;
     import javax.servlet.http.HttpSessionListener;
     
    -public class HttpSessionListenerImpl2 extends AbstractListener implements 
HttpSessionListener {
    +public class SessionCountingListener extends ListenerStoredInSessionContext
    +    implements HttpSessionListener {
    +  private final AtomicInteger sessionCount = new AtomicInteger();
    --- End diff --
    
    Is this sessionCount field used?


> Generic session replication module leaves native sessions around even in 
> proxy mode
> -----------------------------------------------------------------------------------
>
>                 Key: GEODE-3513
>                 URL: https://issues.apache.org/jira/browse/GEODE-3513
>             Project: Geode
>          Issue Type: Bug
>          Components: http session
>            Reporter: Dan Smith
>            Assignee: Dan Smith
>
> The session module for app servers is creating native sessions in the user's 
> application server and never cleaning them up in client/server mode.
> In proxy mode this means we end up using up memory for the session, even 
> though we are fetching the session from the server on every request.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to