[
https://issues.apache.org/jira/browse/GEODE-3502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146015#comment-16146015
]
ASF GitHub Bot commented on GEODE-3502:
---------------------------------------
GitHub user nabarunnag opened a pull request:
https://github.com/apache/geode/pull/749
GEODE-3502: Added awaitility clauses.
* Added awaitility clauses while waiting for the stat comparison checks
* Replaced the deprecated Wait Criterion with Awaitility clause with
increased timeout
* Replaced the invokeAsync with invoke to make the test identical to
the one in ClientHealthStatsDUnitTest
* Removed the commented out flaky tag
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3502
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/749.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #749
----
commit 1c24be8dfb1e57d6fa8db9687110ffff3890fdde
Author: nabarun <[email protected]>
Date: 2017-08-29T18:05:28Z
GEODE-3502: Added awaitility clauses.
* Added awaitility clauses while waiting for the stat comparison checks
* Replaced the deprecated Wait Criterion with Awaitility clause with
increased timeout
* Replaced the invokeAsync with invoke to make the test identical to
the one in ClientHealthStatsDUnitTest
* Removed the commented out flaky tag
----
> CI Failure: Bug48571DUnitTest > testStatsMatchWithSize FAILED
> -------------------------------------------------------------
>
> Key: GEODE-3502
> URL: https://issues.apache.org/jira/browse/GEODE-3502
> Project: Geode
> Issue Type: Bug
> Components: client queues
> Affects Versions: 1.3.0
> Reporter: Shelley Lynn Hughes-Godfrey
>
> org.apache.geode.internal.cache.ha.Bug48571DUnitTest > testStatsMatchWithSize
> FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.internal.cache.ha.Bug48571DUnitTest$$Lambda$29/480440298.run
> in VM 0 running on Host adb2c056aa53 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:387)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:357)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:302)
> at
> org.apache.geode.internal.cache.ha.Bug48571DUnitTest.testStatsMatchWithSize(Bug48571DUnitTest.java:144)
> Caused by:
> java.lang.AssertionError: expected:<326> but was:<327>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at
> org.apache.geode.internal.cache.ha.Bug48571DUnitTest.verifyStats(Bug48571DUnitTest.java:299)
> at
> org.apache.geode.internal.cache.ha.Bug48571DUnitTest.lambda$testStatsMatchWithSize$bb17a952$6(Bug48571DUnitTest.java:144)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
