[
https://issues.apache.org/jira/browse/GEODE-3283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151013#comment-16151013
]
ASF GitHub Bot commented on GEODE-3283:
---------------------------------------
Github user nreich commented on a diff in the pull request:
https://github.com/apache/geode/pull/753#discussion_r136642718
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ImportDataIntegrationTest.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
ANY KIND, either express
+ * or implied. See the License for the specific language governing
permissions and limitations under
+ * the License.
+ *
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.Assert.assertEquals;
+
+import java.util.stream.IntStream;
+
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.util.CommandStringBuilder;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+
+@Category(IntegrationTest.class)
+public class ImportDataIntegrationTest extends SnapshotDataIntegrationTest
{
--- End diff --
I tried to include only pretty generic code to share between the two tests,
though (as with any code) it is always possible that they could diverge in the
future, making the abstract class less / no longer valuable. I am not opposed
to duplicating the shared code in each location instead if there is a stronger
preference towards ease of test extension / modification over DRYness.
> Add gfsh option on export/import to parallelize a snapshot for PRs
> ------------------------------------------------------------------
>
> Key: GEODE-3283
> URL: https://issues.apache.org/jira/browse/GEODE-3283
> Project: Geode
> Issue Type: Sub-task
> Components: snapshot
> Reporter: Fred Krone
> Assignee: Nick Reich
>
> This is related to another ticket to improve snapshot export time
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
