[
https://issues.apache.org/jira/browse/GEODE-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166966#comment-16166966
]
Bruce Schuchardt commented on GEODE-3085:
-----------------------------------------
Here are my notes from investigating these methods:
getSocketHost(), getSocketPort(), getSocketHost()
used by some old-client command classes
used by management to get a list of unique client machines and also in
reporting client version information
getSocketPort() is also used by a method used in a small handful of tests
getSocketString()
used in all of the old-client command classes
getSocket()
used in the old-client handshake and in the new protocol
GenericProtocolServerConnection.doOneMessage()
> Investigate replacement of getSocketHost(), getSocketPort(),
> getSocketAddress()
> -------------------------------------------------------------------------------
>
> Key: GEODE-3085
> URL: https://issues.apache.org/jira/browse/GEODE-3085
> Project: Geode
> Issue Type: Sub-task
> Components: client/server
> Reporter: Galen O'Sullivan
> Fix For: 1.3.0
>
>
> Investigate replacement of getSocketHost(), getSocketPort(),
> getSocketAddress() in {{ServerConnection}}, given potentially messy
> interactions between new and old protocols.
> More specific details:
> {{ServerConnection}} has two methods, {{getSocketHost()}} and
> {{getSocketPort()}}, which are only used in a handful of places. Look at
> where they are used and either provide working implementations for
> {{NewClientServerConnection}} or remove their use / add a new API call on
> {{ServerConnection}}. Pay close attention that it doesn't tie into legacy
> commands we don't want to interact with in the new protocol.
> Also review getSocketAddress(), which may be tied to an observed but yet
> undocumented bug.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
