[
https://issues.apache.org/jira/browse/GEODE-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Rhomberg updated GEODE-3652:
------------------------------------
Description: Test hooks represent suboptimal design at best and significant
security, stability, and performance concerns in practice. These test hooks
should be removed. Tests relying on them should, for instance, use Mockito
spys to inject test code in the desired location. This will likely require
nontrivial refactoring of the class in question. (was: Test hooks represent
suboptimal design at best and significant security, stability, and performance
concerns in practice. These test hooks should be removed. Tests relying on
them should, for instance, use Mockito spys to inject test code in the desired
location. This will likely require nontrivial refactoring of the class in
question.
Subtasks will be added for the 21 classes matching the regex
{noformat}
public.* static.*hook
{noformat})
> Remove test hooks from production code.
> ---------------------------------------
>
> Key: GEODE-3652
> URL: https://issues.apache.org/jira/browse/GEODE-3652
> Project: Geode
> Issue Type: Bug
> Components: general, tests
> Reporter: Patrick Rhomberg
>
> Test hooks represent suboptimal design at best and significant security,
> stability, and performance concerns in practice. These test hooks should be
> removed. Tests relying on them should, for instance, use Mockito spys to
> inject test code in the desired location. This will likely require
> nontrivial refactoring of the class in question.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
