[ 
https://issues.apache.org/jira/browse/GEODE-3096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187190#comment-16187190
 ] 

John Blum commented on GEODE-3096:
----------------------------------

Regarding...

{quote}Use one single ShellCommandController to replace all command 
controllers{quote}

Why would you do that?  That moves your further from proper _Separation of 
Concerns_ and notion of actual Resource abstractions.  Currently, the 
Controller classes were broken down by concern, even more so than the actual 
_Gfsh_ shell command classes.


> Refactor and unify GFSH http clients
> ------------------------------------
>
>                 Key: GEODE-3096
>                 URL: https://issues.apache.org/jira/browse/GEODE-3096
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh, management
>            Reporter: Jared Stewart
>            Assignee: Jared Stewart
>
> We currently have at least two separate HTTP clients used by GFSH over HTTP.  
> (See SimpleHttpRequester, AbstractHttpOperationInvoker, 
> RestHttpOperationInvoker, SimpleHttpOperationInvoker).  This results in a lot 
> of duplicated and inconsistent logic.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to