[
https://issues.apache.org/jira/browse/GEODE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jared Stewart updated GEODE-3872:
---------------------------------
Description:
We have started to accumulate several flavors of _executeCommand_ methods on
GfshShellConnectionRule that implicitly make certain kinds of assertions. (For
example, assertions on the command result status or on the output text.) It
would make the code more maintainable to separate the various assertion methods
into a separate class and to have a single executeCommand method.
(See e.g.
http://joel-costigliola.github.io/assertj/assertj-core-custom-assertions.html#custom-assertion-class)
was:
We have started to accumulate several flavors of _executeCommand_ methods on
GfshShellConnectionRule that implicitly make certain kinds of assertions. (For
example, assertions on the command result status or on the output text.) It
would make the code more maintainable to separate the various assertion methods
into a separate class.
(See e.g.
http://joel-costigliola.github.io/assertj/assertj-core-custom-assertions.html#custom-assertion-class)
> Consolidate GfshShellConnectionRule assertions
> ----------------------------------------------
>
> Key: GEODE-3872
> URL: https://issues.apache.org/jira/browse/GEODE-3872
> Project: Geode
> Issue Type: Improvement
> Components: gfsh, tests
> Reporter: Jared Stewart
>
> We have started to accumulate several flavors of _executeCommand_ methods on
> GfshShellConnectionRule that implicitly make certain kinds of assertions.
> (For example, assertions on the command result status or on the output text.)
> It would make the code more maintainable to separate the various assertion
> methods into a separate class and to have a single executeCommand method.
> (See e.g.
> http://joel-costigliola.github.io/assertj/assertj-core-custom-assertions.html#custom-assertion-class)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
