[
https://issues.apache.org/jira/browse/GEODE-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217893#comment-16217893
]
ASF GitHub Bot commented on GEODE-3903:
---------------------------------------
WireBaron commented on a change in pull request #974: GEODE-3903: Splitting of
client protocol code from protobuf implementation
URL: https://github.com/apache/geode/pull/974#discussion_r146715727
##########
File path:
geode-client-protocol/src/main/java/org/apache/geode/internal/protocol/OperationContext.java
##########
@@ -19,46 +19,41 @@
import org.apache.geode.annotations.Experimental;
import org.apache.geode.internal.protocol.operations.OperationHandler;
-import org.apache.geode.internal.protocol.protobuf.ClientProtocol;
import org.apache.geode.security.ResourcePermission;
@Experimental
-public class OperationContext<OperationRequest, OperationResponse> {
- private final OperationHandler<OperationRequest, OperationResponse>
operationHandler;
- private final Function<ClientProtocol.Request, OperationRequest> fromRequest;
- private final Function<OperationResponse, ClientProtocol.Response.Builder>
toResponse;
- private final Function<ClientProtocol.ErrorResponse,
ClientProtocol.Response.Builder> toErrorResponse;
+public abstract class OperationContext<OperationRequest, OperationResponse,
ErrorResp, ProtocolRequest, ProtocolResp> {
Review comment:
This is true of the change set in general, but you've got an odd mix of
condensed names (ErrorResp) and more explicit names (OperationResponse).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor current client protocol work to split the protocol from protobuf
> -------------------------------------------------------------------------
>
> Key: GEODE-3903
> URL: https://issues.apache.org/jira/browse/GEODE-3903
> Project: Geode
> Issue Type: Improvement
> Components: client/server
> Reporter: Udo Kohlmeyer
> Assignee: Udo Kohlmeyer
>
> Currently the protobuf protocol work is all in 1 module. Split the modules
> into 2 modules:
> * geode-client-protocol - specific to protocol only work
> * geode-protobuf - specific to the protobuf implementation for the client
> protocol
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
