[
https://issues.apache.org/jira/browse/GEODE-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225727#comment-16225727
]
ASF GitHub Bot commented on GEODE-3338:
---------------------------------------
ladyVader opened a new pull request #995: GEODE-3338 Refactor WAN command tests
to use new Rules
URL: https://github.com/apache/geode/pull/995
This commit includes refactoring the 13 test classes in WAN Command tests to
use the new Test Rules vs. the deprecated CliCommandTestBase.
In addition to GEODE-3338, please refer to GEODE-3362 through GEODE-3374
(one per test plus one to remove WANCommandTestBase) all of which are
included
as sub jiras for GEODE-1359.
- Remove use of deprecated APIs in CliCommandTestBase
- Remove WANCommandTestBase (all classes extended this class)
- Refactored to use new rules
- Removed FlakyTest specification for GEODE-1355, GEODE-1395, GEODE-1418
and GEODE-1448.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactor CreateAndDestroyGatewaySenderCommandsDUnitTest.java to use test rules
> ------------------------------------------------------------------------------
>
> Key: GEODE-3338
> URL: https://issues.apache.org/jira/browse/GEODE-3338
> Project: Geode
> Issue Type: Sub-task
> Components: tests
> Reporter: Patrick Rhomberg
>
> {{CreateAndDestroyGatewaySenderCommandsDUnitTest}} is using
> {{CliCommandTestBase}}, which is a deprecated class. It should be refactored
> to use more current test rules.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
