[ 
https://issues.apache.org/jira/browse/GEODE-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234502#comment-16234502
 ] 

ASF GitHub Bot commented on GEODE-3938:
---------------------------------------

jhuynh1 commented on issue #1003: Fix for GEODE-3938
URL: https://github.com/apache/geode/pull/1003#issuecomment-341191656
 
 
   Hi, 
   
   Thanks for the contribution and good job!  The oql.g is tough to navigate 
and I'm glad you were able make it to work out!
   
   I've made some modifications to this PR (just refactored/added a test or 
two) and created a pull request onto your fork.  If you can apply the changes 
and update this PR that would be great.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Allow query parameters within the to_date preset query function
> ---------------------------------------------------------------
>
>                 Key: GEODE-3938
>                 URL: https://issues.apache.org/jira/browse/GEODE-3938
>             Project: Geode
>          Issue Type: New Feature
>          Components: querying
>            Reporter: Juan José Ramos Cassella
>            Assignee: Juan José Ramos Cassella
>
> Currently the {{to_date}} preset query function doesn't allow the user to 
> pass the date to format as a query parameter, which forces the user 
> application to add boilerplate code to manually parse the date.
> Apparently there's no internal blockers preventing such a feature to be 
> enabled, and the change just implies a small change in {{oql.g}}:
> {code}
> conversionExpr :
>   (
>     ...
>         |
>            (  
>               (
>                
> "to_date"^<AST=org.apache.geode.cache.query.internal.parse.ASTConversionExpr>
>               )
>               TOK_LPAREN!
>               (stringLiteral | queryParam) TOK_COMMA! stringLiteral
>               TOK_RPAREN! 
>            )    
>     ...
>   )
>     ;
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to