[
https://issues.apache.org/jira/browse/GEODE-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235188#comment-16235188
]
ASF GitHub Bot commented on GEODE-3778:
---------------------------------------
jinmeiliao closed pull request #1004: GEODE-3778: mark tests flaky
URL: https://github.com/apache/geode/pull/1004
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherRemoteIntegrationTest.java
b/geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherRemoteIntegrationTest.java
index 085e4da975..6b75ecaed9 100755
---
a/geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherRemoteIntegrationTest.java
+++
b/geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherRemoteIntegrationTest.java
@@ -32,6 +32,7 @@
import org.apache.geode.distributed.LocatorLauncher.LocatorState;
import org.apache.geode.internal.GemFireVersion;
import org.apache.geode.internal.process.ProcessControllerFactory;
+import org.apache.geode.test.junit.categories.FlakyTest;
import org.apache.geode.test.junit.categories.IntegrationTest;
/**
@@ -69,6 +70,7 @@ public void startCreatesLogFile() throws Exception {
}
@Test
+ @Category(FlakyTest.class) // GEODE-3506
public void startDeletesStaleControlFiles() throws Exception {
File stopRequestFile = givenControlFile(getStopRequestFileName());
File statusRequestFile = givenControlFile(getStatusRequestFileName());
diff --git
a/geode-core/src/test/java/org/apache/geode/internal/cache/DeprecatedCacheServerLauncherIntegrationTest.java
b/geode-core/src/test/java/org/apache/geode/internal/cache/DeprecatedCacheServerLauncherIntegrationTest.java
index e2ac109cb1..232d2b3dff 100755
---
a/geode-core/src/test/java/org/apache/geode/internal/cache/DeprecatedCacheServerLauncherIntegrationTest.java
+++
b/geode-core/src/test/java/org/apache/geode/internal/cache/DeprecatedCacheServerLauncherIntegrationTest.java
@@ -70,6 +70,7 @@
import
org.apache.geode.internal.cache.control.InternalResourceManager.ResourceObserverAdapter;
import org.apache.geode.internal.cache.xmlcache.CacheXml;
import org.apache.geode.internal.logging.LogService;
+import org.apache.geode.test.junit.categories.FlakyTest;
import org.apache.geode.test.junit.categories.IntegrationTest;
import org.apache.geode.test.process.ProcessWrapper;
@@ -275,6 +276,7 @@ public void testRebalance() throws Exception {
}
@Test
+ @Category(FlakyTest.class) // GEODE-3939
public void testCreateBuckets() throws Exception {
this.registry = LocateRegistry.createRegistry(this.controllerNamingPort);
this.status = new RebalanceStatus();
diff --git
a/geode-core/src/test/java/org/apache/geode/internal/process/FileProcessControllerIntegrationTest.java
b/geode-core/src/test/java/org/apache/geode/internal/process/FileProcessControllerIntegrationTest.java
index 82f9b8f6b5..80d267c69f 100755
---
a/geode-core/src/test/java/org/apache/geode/internal/process/FileProcessControllerIntegrationTest.java
+++
b/geode-core/src/test/java/org/apache/geode/internal/process/FileProcessControllerIntegrationTest.java
@@ -48,6 +48,7 @@
import org.apache.geode.internal.process.io.EmptyFileWriter;
import org.apache.geode.internal.process.io.IntegerFileWriter;
import org.apache.geode.internal.process.io.StringFileWriter;
+import org.apache.geode.test.junit.categories.FlakyTest;
import org.apache.geode.test.junit.categories.IntegrationTest;
/**
@@ -195,6 +196,7 @@ public void stop_withStopRequestFileExists_doesNotFail()
throws Exception {
}
@Test
+ @Category(FlakyTest.class) // GEODE-3778
public void status_withStatusRequestFileExists_doesNotFail() throws
Exception {
// arrange
FileProcessController controller = new FileProcessController(params, pid);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> FileProcessControllerIntegrationTest.status_withStatusRequestFileExists_doesNotFail
> fails intermittently
> --------------------------------------------------------------------------------------------------------
>
> Key: GEODE-3778
> URL: https://issues.apache.org/jira/browse/GEODE-3778
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Kirk Lund
> Priority: Major
> Fix For: 1.4.0
>
>
> FileProcessControllerIntegrationTest tests FileProcessController which GFSH
> uses to control running Locator and Server processes.
> So far this test has failed 3 times in CI with 2 different stacks:
> {noformat}
> org.apache.geode.internal.process.FileProcessControllerIntegrationTest >
> status_withStatusRequestFileExists_doesNotFail FAILED
> java.lang.AssertionError:
> Expecting file:
> </tmp/junit6965412555588538059/vf.gf.locator.status>
> to exist.
> at
> org.apache.geode.internal.process.io.StringFileWriter.writeToFile(StringFileWriter.java:40)
> at
> org.apache.geode.internal.process.FileProcessControllerIntegrationTest.status_withStatusRequestFileExists_doesNotFail(FileProcessControllerIntegrationTest.java:212)
> {noformat}
> {noformat}
> org.apache.geode.internal.process.FileProcessControllerIntegrationTest >
> status_withStatusRequestFileExists_doesNotFail FAILED
> java.lang.InterruptedException: sleep interrupted
> at java.lang.Thread.sleep(Native Method)
> at
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:143)
> at
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:89)
> at
> org.apache.geode.internal.process.FileProcessControllerIntegrationTest.lambda$status_withStatusRequestFileExists_doesNotFail$4(FileProcessControllerIntegrationTest.java:206)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
