[
https://issues.apache.org/jira/browse/GEODE-3605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236772#comment-16236772
]
ASF GitHub Bot commented on GEODE-3605:
---------------------------------------
pivotal-jbarrett closed pull request #141: GEODE-3605: Remove deprecated
methods from public API
URL: https://github.com/apache/geode-native/pull/141
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cppcache/include/geode/CacheableDate.hpp
b/cppcache/include/geode/CacheableDate.hpp
index 99dce9cc..a4a44dbb 100644
--- a/cppcache/include/geode/CacheableDate.hpp
+++ b/cppcache/include/geode/CacheableDate.hpp
@@ -90,27 +90,6 @@ class CPPCACHE_EXPORT CacheableDate : public CacheableKey {
/** @return true if this key matches other. */
virtual bool operator==(const CacheableKey& other) const;
- /**
- * @return day of the month.
- * @deprecated Use localtime or similar for calendar conversions.
- */
- __DEPRECATED__("Use localtime or similar for calendar conversions.")
- virtual int day() const;
-
- /**
- * @return month 1(Jan) - 12(Dec) .
- * @deprecated Use localtime or similar for calendar conversions.
- */
- __DEPRECATED__("Use localtime or similar for calendar conversions.")
- virtual int month() const;
-
- /**
- * @return year, example 1999.
- * @deprecated Use localtime or similar for calendar conversions.
- */
- __DEPRECATED__("Use localtime or similar for calendar conversions.")
- virtual int year() const;
-
/** @return milliseconds elapsed since January 1, 1970, 00:00:00 GMT. */
virtual int64_t milliseconds() const;
diff --git a/cppcache/src/CacheableDate.cpp b/cppcache/src/CacheableDate.cpp
index 04b7b7b2..da8220b5 100644
--- a/cppcache/src/CacheableDate.cpp
+++ b/cppcache/src/CacheableDate.cpp
@@ -60,27 +60,6 @@ bool CacheableDate::operator==(const CacheableKey& other)
const {
return m_timevalue == otherDt.m_timevalue;
}
-int CacheableDate::day() const {
- struct tm date = {0};
- time_t sec = m_timevalue / 1000;
- ACE_OS::localtime_r(&sec, &date);
- return date.tm_mday;
-}
-
-int CacheableDate::month() const {
- struct tm date = {0};
- time_t sec = m_timevalue / 1000;
- ACE_OS::localtime_r(&sec, &date);
- return date.tm_mon + 1;
-}
-
-int CacheableDate::year() const {
- struct tm date = {0};
- time_t sec = m_timevalue / 1000;
- ACE_OS::localtime_r(&sec, &date);
- return date.tm_year + 1900;
-}
-
int64_t CacheableDate::milliseconds() const { return m_timevalue; }
int32_t CacheableDate::hashcode() const {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove deprecated methods from Public API.
> ------------------------------------------
>
> Key: GEODE-3605
> URL: https://issues.apache.org/jira/browse/GEODE-3605
> Project: Geode
> Issue Type: Task
> Components: native client
> Reporter: Jacob S. Barrett
> Priority: Major
>
> Remove deprecated methods on public API.
> See:
> CacheableDate.hpp
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
