[
https://issues.apache.org/jira/browse/GEODE-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238098#comment-16238098
]
ASF GitHub Bot commented on GEODE-3007:
---------------------------------------
metatype commented on a change in pull request #1011: GEODE-3007: Simplify
support for custom GFSH commands
URL: https://github.com/apache/geode/pull/1011#discussion_r148854953
##########
File path: geode-assembly/build.gradle
##########
@@ -193,19 +195,20 @@ def cp = {
it.contains('log4j-slf4j-impl') ||
it.contains('shiro') ||
it.contains('slf4j-api') ||
+ it.contains('spring-beans') ||
Review comment:
This might cause a conflict with jars on the `gemfire-web` classpath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Simplify support for custom GFSH commands
> -----------------------------------------
>
> Key: GEODE-3007
> URL: https://issues.apache.org/jira/browse/GEODE-3007
> Project: Geode
> Issue Type: Improvement
> Components: docs, gfsh
> Reporter: Jared Stewart
> Assignee: Jared Stewart
> Priority: Major
>
> Geode currently supports three ways to load GFSH commands:
> 1. Scan the classpath for commands in
> "org.apache.geode.management.internal.cli.commands”
> 2. Scan the classpath for commands in a package specified by a user via the
> “user-command-packages” system property.
> 3. Scan the classpath for commands registered in files inside
> META-INF.services (e.g.
> "geode-core/src/test/resources/META-INF/services/org.springframework.shell.core.CommandMarker”)
>
> After the improvements made by GEODE-2989, there is no reason to require a
> user to specify the location of their custom commands via one of these
> mechanisms. Instead, we should simply scan the entire classpath for any
> classes implementing CommandMarker (regardless of whatever packages they live
> in).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
