[
https://issues.apache.org/jira/browse/GEODE-3953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240968#comment-16240968
]
ASF GitHub Bot commented on GEODE-3953:
---------------------------------------
ladyVader opened a new pull request #1020: GEODE-3953: Incorrect use of
.equals() for comparison of fieldname ar…
URL: https://github.com/apache/geode/pull/1020
…rays
GEODE-3954: Misleading Exception message with mismatched fieldAnalyzers
- corrected equals comparisons of fieldname arrays
- corrected Exception message for mismatched fieldAnalyzers to refer to
field analyzers (vs. fieldnames) when remote and local fieldAnalyzers are
different sizes
- corrected Exception message to display fieldAnalyzers vs. fieldnames when
remote and local fieldAnalyzer maps are different sizes
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Lucene create index can fail due to comparison of fieldnames as an array
> ------------------------------------------------------------------------
>
> Key: GEODE-3953
> URL: https://issues.apache.org/jira/browse/GEODE-3953
> Project: Geode
> Issue Type: Bug
> Components: lucene
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Shelley Lynn Hughes-Godfrey
> Assignee: Shelley Lynn Hughes-Godfrey
> Priority: Trivial
>
> Note that Arrays.equals() fails if the entries are in a different order ...
> but order here is not significant and we should not fail the profile
> comparison
> {noformat}
> // Verify fields are the same
> if (!Arrays.equals(remoteProfile.getFieldNames(), getFieldNames())) {
> return
> LocalizedStrings.LuceneService_CANNOT_CREATE_INDEX_0_ON_REGION_1_WITH_FIELDS_2_BECAUSE_ANOTHER_MEMBER_DEFINES_THE_SAME_INDEX_WITH_FIELDS_3
> .toString(getIndexName(), regionPath,
> Arrays.toString(getFieldNames()),
> Arrays.toString(remoteProfile.getFieldNames()));
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
