[
https://issues.apache.org/jira/browse/GEODE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242390#comment-16242390
]
ASF GitHub Bot commented on GEODE-3136:
---------------------------------------
dgkimura commented on a change in pull request #144: GEODE-3136: Convert time
values to std::chrono::duration.
URL: https://github.com/apache/geode-native/pull/144#discussion_r149405518
##########
File path: cppcache/include/geode/AttributesMutator.hpp
##########
@@ -64,13 +68,13 @@ class CPPCACHE_EXPORT AttributesMutator {
virtual ~AttributesMutator();
/** Sets the idleTimeout duration for region entries.
- * @param idleTimeout the idleTimeout in seconds for entries in this region.
+ * @param idleTimeout the idleTimeout for entries in this region.
* @return the previous value.
* @throw IllegalStateException if the new idleTimeout changes entry
* expiration from
* disabled to enabled or enabled to disabled.
*/
- int32_t setEntryIdleTimeout(int32_t idleTimeout);
+ std::chrono::seconds setEntryIdleTimeout(std::chrono::seconds idleTimeout);
Review comment:
I like it, self-documenting code!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace all public API time values with std::chrono types
> ---------------------------------------------------------
>
> Key: GEODE-3136
> URL: https://issues.apache.org/jira/browse/GEODE-3136
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Jacob S. Barrett
> Assignee: Jacob S. Barrett
>
> Remove ambiguity of time values by using
> [{{std::chrono}}|http://en.cppreference.com/w/cpp/chrono] types in the public
> API.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
