[
https://issues.apache.org/jira/browse/GEODE-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245007#comment-16245007
]
ASF GitHub Bot commented on GEODE-3601:
---------------------------------------
dschneider-pivotal closed pull request #1036: GEODE-3601: remove getExisting
call
URL: https://github.com/apache/geode/pull/1036
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/geode-core/src/main/java/org/apache/geode/internal/cache/TXCommitMessage.java
b/geode-core/src/main/java/org/apache/geode/internal/cache/TXCommitMessage.java
index c927239267..1b972471f6 100644
---
a/geode-core/src/main/java/org/apache/geode/internal/cache/TXCommitMessage.java
+++
b/geode-core/src/main/java/org/apache/geode/internal/cache/TXCommitMessage.java
@@ -1300,8 +1300,7 @@ protected void txApplyEntryOpAdjunctOnly(FarSideEntryOp
entryOp) {
PartitionedRegion pr = (PartitionedRegion) r;
BucketRegion br = pr.getBucketRegion(entryOp.key);
Set bucketOwners = br.getBucketOwners();
- InternalDistributedMember thisMember =
- GemFireCacheImpl.getExisting().getDistributionManager().getId();
+ InternalDistributedMember thisMember =
this.r.getDistributionManager().getId();
if (bucketOwners.contains(thisMember)) {
return;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> refactor
> org.apache.geode.internal.cache.TXCommitMessage.RegionCommit.txApplyEntryOpAdjunctOnly(FarSideEntryOp)
> to not call GemFireCacheImpl.getExisting
> --------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-3601
> URL: https://issues.apache.org/jira/browse/GEODE-3601
> Project: Geode
> Issue Type: Sub-task
> Components: transactions
> Reporter: Darrel Schneider
> Assignee: Darrel Schneider
>
> TXCommitMessage.RegionCommit.txApplyEntryOpAdjunctOnly should be changed to
> not call GemFireCacheImpl.getExisting. Instead it could use dm.getCache.
> A DM can be passed to it from
> org.apache.geode.internal.cache.TXCommitMessage.basicProcess() through
> basicProcessOps and processAdjunctOnly
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
