[
https://issues.apache.org/jira/browse/GEODE-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263169#comment-16263169
]
ASF GitHub Bot commented on GEODE-4007:
---------------------------------------
WireBaron opened a new pull request #1087: GEODE-4007: Authentication/Handshake
errors should close the socket
URL: https://github.com/apache/geode/pull/1087
@PivotalSarge @galen-pivotal @bschuchardt @upthewaterspout
This will cause the connection to be closed whenever a handshake or
authentication message fails.
The connection will also be broken if we ever receive an unexpected
handshake or
authenticantication message.
Signed-off-by: Brian Rowe <[email protected]>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Authentication failures/bad handshake should close the socket from the server
> side
> ----------------------------------------------------------------------------------
>
> Key: GEODE-4007
> URL: https://issues.apache.org/jira/browse/GEODE-4007
> Project: Geode
> Issue Type: Bug
> Components: client/server
> Reporter: Brian Rowe
>
> Ensure after failed auth/handshake the server (after sending error response)
> closes the socket and cleans up.
> While going over the code together, it looks like maybe authentication errors
> simply leave the socket in a state where it is expecting another
> authentication request. It might be better to close the socket from the
> server side for various error conditions like a failed handshake or
> authentication.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
