[
https://issues.apache.org/jira/browse/GEODE-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263572#comment-16263572
]
ASF GitHub Bot commented on GEODE-3788:
---------------------------------------
PurelyApplied commented on a change in pull request #1084: GEODE-3788: add
alter async-event-queue command and tests
URL: https://github.com/apache/geode/pull/1084#discussion_r152702785
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/cli/json/GfJsonObject.java
##########
@@ -305,6 +305,11 @@ public boolean has(String key) {
return jsonObject.keys();
}
+ /**
+ * this returns the column size
+ *
+ * @return
Review comment:
The description should be in-line with `@return` for the javadoc, i.e.,
```
/**
* @return the column size of the jsonObject
*/
public int size() {
return jsonObject.length();
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> alter async event queue attributes
> ----------------------------------
>
> Key: GEODE-3788
> URL: https://issues.apache.org/jira/browse/GEODE-3788
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
> Reporter: Swapnil Bawaskar
>
> We should add a new {{alter async-event-queue}} gfsh command that will allow
> users to change the following attributes on the AsyncEventQueue:
> - batch size
> - batch time interval
> - maximum queue memory
> Attributes changed with this command should only be reflected in cluster
> configuration. We will require users to do a rolling re-start of the servers
> for the new settings to take effect.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
