[
https://issues.apache.org/jira/browse/GEODE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267338#comment-16267338
]
ASF GitHub Bot commented on GEODE-3969:
---------------------------------------
galen-pivotal closed pull request #1047: GEODE-3969: Remove CallbackArgs from
protobuf requests
URL: https://github.com/apache/geode/pull/1047
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/geode-protobuf/src/main/proto/v1/basicTypes.proto
b/geode-protobuf/src/main/proto/v1/basicTypes.proto
index 9126efefbd..4fd0c96c0d 100644
--- a/geode-protobuf/src/main/proto/v1/basicTypes.proto
+++ b/geode-protobuf/src/main/proto/v1/basicTypes.proto
@@ -55,13 +55,6 @@ enum EncodingType {
JSON = 10;
}
-message CallbackArguments {
- oneof callbackArgs {
- google.protobuf.Empty hasCallbackArgument = 1;
- EncodedValue callbackValue = 2;
- }
-}
-
message Region {
string name = 1;
string dataPolicy = 2;
diff --git a/geode-protobuf/src/main/proto/v1/clientProtocol.proto
b/geode-protobuf/src/main/proto/v1/clientProtocol.proto
index 95a0fdc9c2..63f820b401 100644
--- a/geode-protobuf/src/main/proto/v1/clientProtocol.proto
+++ b/geode-protobuf/src/main/proto/v1/clientProtocol.proto
@@ -35,18 +35,17 @@ message Message {
}
message Request {
- CallbackArguments callbackArg = 1;
oneof requestAPI {
- PutRequest putRequest = 2;
- GetRequest getRequest = 3;
- PutAllRequest putAllRequest = 4;
- GetAllRequest getAllRequest = 5;
- RemoveRequest removeRequest = 6;
- RemoveAllRequest removeAllRequest = 7;
+ PutRequest putRequest = 10;
+ GetRequest getRequest = 11;
+ PutAllRequest putAllRequest = 12;
+ GetAllRequest getAllRequest = 13;
+ RemoveRequest removeRequest = 14;
+ RemoveAllRequest removeAllRequest = 15;
- GetAvailableServersRequest getAvailableServersRequest = 42;
- GetRegionNamesRequest getRegionNamesRequest = 43;
- GetRegionRequest getRegionRequest = 44;
+ GetAvailableServersRequest getAvailableServersRequest = 40;
+ GetRegionNamesRequest getRegionNamesRequest = 41;
+ GetRegionRequest getRegionRequest = 42;
AuthenticationRequest authenticationRequest = 100;
HandshakeRequest handshakeRequest = 101;
@@ -55,21 +54,21 @@ message Request {
message Response {
oneof responseAPI {
- PutResponse putResponse = 2;
- GetResponse getResponse = 3;
- PutAllResponse putAllResponse = 4;
- GetAllResponse getAllResponse = 5;
- RemoveResponse removeResponse = 6;
- RemoveAllResponse removeAllResponse = 7;
+ PutResponse putResponse = 10;
+ GetResponse getResponse = 11;
+ PutAllResponse putAllResponse = 12;
+ GetAllResponse getAllResponse = 13;
+ RemoveResponse removeResponse = 14;
+ RemoveAllResponse removeAllResponse = 15;
- ErrorResponse errorResponse = 13;
-
- GetAvailableServersResponse getAvailableServersResponse = 42;
- GetRegionNamesResponse getRegionNamesResponse = 43;
- GetRegionResponse getRegionResponse = 44;
+ GetAvailableServersResponse getAvailableServersResponse = 40;
+ GetRegionNamesResponse getRegionNamesResponse = 41;
+ GetRegionResponse getRegionResponse = 42;
AuthenticationResponse authenticationResponse = 100;
HandshakeResponse handshakeResponse = 101;
+
+ ErrorResponse errorResponse = 1000;
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Protobuf protocol requests includes a CallbackArgs field
> --------------------------------------------------------
>
> Key: GEODE-3969
> URL: https://issues.apache.org/jira/browse/GEODE-3969
> Project: Geode
> Issue Type: Bug
> Components: client/server
> Reporter: Brian Rowe
>
> We eventually want to support allowing clients to pass arguments to cache
> listeners in their requests, but this functionality is not going to be
> present in v1. Having this field is therefore misleading and it should be
> removed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
