[
https://issues.apache.org/jira/browse/GEODE-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267474#comment-16267474
]
ASF GitHub Bot commented on GEODE-3571:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #158: feature/GEODE-3571
URL: https://github.com/apache/geode-native/pull/158#discussion_r153315545
##########
File path: cppcache/test/AttributesFactoryTest.cpp
##########
@@ -23,36 +23,40 @@ using namespace apache::geode::client;
TEST(AttributesFactoryTest, setEntryIdleTimeoutSeconds) {
AttributesFactory attributesFactory;
- attributesFactory.setEntryIdleTimeout(ExpirationAction::DESTROY,
- std::chrono::seconds(10));
std::shared_ptr<RegionAttributes> regionAttributes =
- attributesFactory.createRegionAttributes();
+ attributesFactory
Review comment:
Similar to the comments above I would add a test that makes sure the the
return from each set call is a reference to the same object we called the set
on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> API should move from factory pattern to builder pattern and fluent model
> ------------------------------------------------------------------------
>
> Key: GEODE-3571
> URL: https://issues.apache.org/jira/browse/GEODE-3571
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Mark Hanson
>
> Discussion here http://markmail.org/thread/femkjloasj4yzvoj
> The basic idea is to move away from the creation of generic objects which are
> then further specified to specifying the object in advance then creating the
> more specific object.
> This in addition to using a model where with each attribute set on an object,
> the this pointer is provided as the return value. This allows call chaining.
> Obvious target changes include
> CacheFactory
> DistributedSystem
> AttributesFactory
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
