[
https://issues.apache.org/jira/browse/GEODE-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267749#comment-16267749
]
ASF GitHub Bot commented on GEODE-4010:
---------------------------------------
WireBaron opened a new pull request #1091: GEODE-4010: Don't use gossip with
new protocol on locator
URL: https://github.com/apache/geode/pull/1091
Signed-off-by: Sarge <[email protected]>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
@PivotalSarge @galen-pivotal @upthewaterspout @bschuchardt
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Locator should not require non-gossip request version to be written for new
> protocol
> ------------------------------------------------------------------------------------
>
> Key: GEODE-4010
> URL: https://issues.apache.org/jira/browse/GEODE-4010
> Project: Geode
> Issue Type: Bug
> Components: client/server
> Reporter: Michael Dodge
> Fix For: 1.4.0
>
>
> When connecting to a server using the new protocol, two bytes must be
> written, the communication mode and the major version. The locator, however,
> currently insists on four bytes of non-gossip request version (all zeros)
> being written _before_ the other two bytes. This insistence should be removed
> to ensure consistent behavior between locator and server for the new protocol.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
