[
https://issues.apache.org/jira/browse/GEODE-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269315#comment-16269315
]
ASF GitHub Bot commented on GEODE-4014:
---------------------------------------
kirklund closed pull request #1089: GEODE-4014: use getVMCount instead of
hardcoding number of VMs
URL: https://github.com/apache/geode/pull/1089
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/geode-core/src/test/java/org/apache/geode/test/dunit/rules/tests/CacheRuleTest.java
b/geode-core/src/test/java/org/apache/geode/test/dunit/rules/tests/CacheRuleTest.java
index 18be09bd2e..d10d4bea5b 100644
---
a/geode-core/src/test/java/org/apache/geode/test/dunit/rules/tests/CacheRuleTest.java
+++
b/geode-core/src/test/java/org/apache/geode/test/dunit/rules/tests/CacheRuleTest.java
@@ -227,10 +227,14 @@ public void
createCacheInAllExplicitly_returnsCacheInAll() throws Exception {
@Test
public void createCacheInAll_createsCluster() throws Exception {
-
assertThat(cacheRule.getCache().getDistributionManager().getViewMembers()).hasSize(6);
- for (int i = 0; i < Host.getHost(0).getVMCount(); i++) {
+ int vmCount = Host.getHost(0).getVMCount();
+
+
assertThat(cacheRule.getCache().getDistributionManager().getViewMembers())
+ .hasSize(vmCount + 2);
+ for (int i = 0; i < vmCount; i++) {
Host.getHost(0).getVM(i).invoke(() -> {
-
assertThat(cacheRule.getCache().getDistributionManager().getViewMembers()).hasSize(6);
+
assertThat(cacheRule.getCache().getDistributionManager().getViewMembers())
+ .hasSize(vmCount + 2);
});
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> CacheRuleTest fails intermittently if prior test used more than default 4
> DUnit VMs
> -----------------------------------------------------------------------------------
>
> Key: GEODE-4014
> URL: https://issues.apache.org/jira/browse/GEODE-4014
> Project: Geode
> Issue Type: Bug
> Components: tests
> Reporter: Kirk Lund
> Assignee: Kirk Lund
> Fix For: 1.4.0
>
>
> {noformat}
> org.apache.geode.test.dunit.rules.tests.CacheRuleTest >
> createCacheInAllCreatesCluster FAILED
> java.lang.AssertionError: java.lang.AssertionError:
> Expected size:<6> but was:<7> in:
> <[172.17.0.5(63:locator)<ec><v0>:32769,
> 172.17.0.5(1)<v47>:32770,
> 172.17.0.5(172)<v48>:32771,
> 172.17.0.5(176)<v49>:32772,
> 172.17.0.5(182)<v50>:32773,
> 172.17.0.5(215)<v51>:32774,
> 172.17.0.5(739)<v52>:32775]>
> at
> org.apache.geode.test.junit.runners.TestRunner.runTestWithValidation(TestRunner.java:45)
> at
> org.apache.geode.test.dunit.rules.tests.CacheRuleTest.createCacheInAllCreatesCluster(CacheRuleTest.java:75)
> Caused by:
> java.lang.AssertionError:
> Expected size:<6> but was:<7> in:
> <[172.17.0.5(63:locator)<ec><v0>:32769,
> 172.17.0.5(1)<v47>:32770,
> 172.17.0.5(172)<v48>:32771,
> 172.17.0.5(176)<v49>:32772,
> 172.17.0.5(182)<v50>:32773,
> 172.17.0.5(215)<v51>:32774,
> 172.17.0.5(739)<v52>:32775]>
> at
> org.apache.geode.test.dunit.rules.tests.CacheRuleTest$CreateCacheInAllCreatesCluster.createCacheInAll_createsCluster(CacheRuleTest.java:230)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.apache.geode.test.junit.rules.serializable.SerializableExternalResource$1.evaluate(SerializableExternalResource.java:37)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> org.apache.geode.test.junit.runners.TestRunner.runTestWithValidation(TestRunner.java:40)
> ... 1 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
