[
https://issues.apache.org/jira/browse/GEODE-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269809#comment-16269809
]
ASF GitHub Bot commented on GEODE-3955:
---------------------------------------
PurelyApplied opened a new pull request #1099: GEODE-3955: Add AEQ and Gateway
Sender information to 'describe region' output.
URL: https://github.com/apache/geode/pull/1099
I feel like the non-trivial refactoring deserves its own commit, if only for
ease of review in this pull request.
My inexperience with `Mockito` is showing through and I got a little carried
away in the `RegionDescriptionJUnitTest`. I don't know if the `spy` on its
consumption in `DescribeRegionCommand` is beyond the scope of a reasonable
JUnit and/or if we have (or should have) proper coverage of that in wider-scope
tests. I don't really like how I dug into the command output JSON. So on the
one hand, I don't really like those tests and could see them getting deleted.
But on the other hand, it is more test coverage in the cheap JUnit category.
Thoughts?
-----
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> The gfsh 'describe region' command doesn't include asyncEventQueueIds or
> gatewaySenderIds
> -----------------------------------------------------------------------------------------
>
> Key: GEODE-3955
> URL: https://issues.apache.org/jira/browse/GEODE-3955
> Project: Geode
> Issue Type: Improvement
> Components: management
> Reporter: Barry Oglesby
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: geode-3955.diff
>
>
> The {{constructor}} and {{getNonDefaultAttributes}} methods in
> {{org.apache.geode.management.internal.cli.domain.RegionAttributesInfo}}
> class would have to be modified to include the {{asyncEventQueueIds}} and
> {{gatewaySenderIds}}.
> I did a quick modification of this class (attached).
> With these changes, 'describe region' looks like:
> {noformat}
> gfsh>describe region --name=/data
> ..........................................................
> Name : data
> Data Policy : partition
> Hosting Members : ln-1
> Non-Default Attributes Shared By Hosting Members
> Type | Name | Value
> --------- | --------------------- | ---------
> Region | data-policy | PARTITION
> | async-event-queue-ids | db
> | size | 0
> | gateway-sender-ids | ny
> Partition | redundant-copies | 1
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
