[
https://issues.apache.org/jira/browse/GEODE-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271102#comment-16271102
]
ASF GitHub Bot commented on GEODE-3288:
---------------------------------------
dgkimura commented on a change in pull request #160: GEODE-3288: Converts char*
to std::string on public API.
URL: https://github.com/apache/geode-native/pull/160#discussion_r153831328
##########
File path: cppcache/src/CacheImpl.cpp
##########
@@ -332,29 +333,27 @@ void CacheImpl::close(bool keepalive) {
bool CacheImpl::isCacheDestroyPending() const { return m_destroyPending; }
void CacheImpl::validateRegionAttributes(
- const char* name, const std::shared_ptr<RegionAttributes>& attrs) const {
- RegionKind kind = getRegionKind(attrs);
- std::string buffer = "Cache::createRegion: \"";
- buffer += name;
- buffer += "\" ";
-
+ const std::string& name,
+ const std::shared_ptr<RegionAttributes>& attrs) const {
+ auto&& kind = getRegionKind(attrs);
Review comment:
Intentional universal reference here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace char* with std::string
> ------------------------------
>
> Key: GEODE-3288
> URL: https://issues.apache.org/jira/browse/GEODE-3288
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Ernest Burghardt
>
> In all public API headers
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
