[ 
https://issues.apache.org/jira/browse/GEODE-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271290#comment-16271290
 ] 

ASF GitHub Bot commented on GEODE-1897:
---------------------------------------

jdeppe-pivotal commented on a change in pull request #1098: GEODE-1897 Docs:  
configure eviction through gfsh
URL: https://github.com/apache/geode/pull/1098#discussion_r153872310
 
 

 ##########
 File path: geode-docs/tools_modules/gfsh/command-pages/create.html.md.erb
 ##########
 @@ -960,6 +961,48 @@ See [Region Data Storage and 
Distribution](../../../developing/region_options/ch
 <td><span class="keyword parmname">\-\-partition-resolver</span></td>
 <td>Specifies the full path to a custom partition resolver. To use the 
provided default partition resolver, specify <code class="ph 
codeph">org.apache.geode.cache.util.StringPrefixPartitionResolver</code>.</td>
 <td></td>
+</tr>
+<tr>
+<td><span class="keyword parmname">\-\-eviction-enabled</span></td>
+<td>Enables eviction, where the eviction policy is controlled by the resource 
manager based on heap percentage.</td>
+<td></td>
+</tr>
+<tr>
+<td><span class="keyword parmname">\-\-eviction-entry-count</span></td>
+<td>Enables eviction, where the eviction policy is based on the number of 
entries in the region.</td>
+<td></td>
+</tr>
+<tr>
+<td><span class="keyword parmname">\-\-eviction-max-memory</span></td>
+<td>Enables eviction, where the eviction policy is based on the amount of 
memory consumed, specified in megabytes.</td>
+<td></td>
+</tr>
+<tr>
+<td><span class="keyword parmname">\-\-eviction-action</span></td>
+<td>Action to take when the eviction threshold is reached.
+<div class="p">
+<table>
+<tbody>
+<tr class="odd">
+<td>local-destroy</td>
+<td>Entry is destroyed locally. Not available for replicated regions.</td>
+</tr>
+<tr class="even">
+<td>overflow-to-disk</td>
+<td>Entry is overflowed to disk and the value set to null in memory. For 
partitioned regions, this provides the most reliable read behavior across the 
region.</td>
 
 Review comment:
   Is it necessary to say `and the value set to null in memory`? Sounds scary 
and I think it might only be relevant as an internal detail.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Users should be able to configure eviction through gfsh
> -------------------------------------------------------
>
>                 Key: GEODE-1897
>                 URL: https://issues.apache.org/jira/browse/GEODE-1897
>             Project: Geode
>          Issue Type: Sub-task
>          Components: docs, gfsh
>            Reporter: Swapnil Bawaskar
>            Assignee: Dave Barnes
>             Fix For: 1.4.0
>
>
> While creating a region in gfsh, users should be able to configure eviction 
> for that region.
> All three modes of eviction should be supported:
> 1. Eviction driven by the resource manager:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE --eviction-enabled
> {noformat}
> 2. eviction driven by entry count in the region:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE 
> --eviction-entry-count=1000
> {noformat}
> 3. eviction driven by bytes used:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE --eviction-max-memory=100
> (value in megabytes)
> {noformat}
> And also specify the eviction action as
> {noformat}
> --eviction-action=overflow-to-disk or
> --eviction-action=local-destroy
> {noformat}
> and an object sizer, so that users can plug-in custom object sizes as
> {noformat}
> --eviction-object-sizer=my.company.geode.MySizer
> {noformat}
> the sizer should only apply to heap and memory based eviction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to