[
https://issues.apache.org/jira/browse/GEODE-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271298#comment-16271298
]
ASF GitHub Bot commented on GEODE-4011:
---------------------------------------
jdeppe-pivotal closed pull request #1100: GEODE-4011: Ensure that LogWrapper is
closed correctly in GfshCommand…
URL: https://github.com/apache/geode/pull/1100
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConcurrentDeployDUnitTest.java
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConcurrentDeployDUnitTest.java
index 05a217aa8b..3449c21335 100644
---
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConcurrentDeployDUnitTest.java
+++
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConcurrentDeployDUnitTest.java
@@ -19,7 +19,6 @@
import java.util.concurrent.TimeUnit;
import org.junit.After;
-import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.experimental.categories.Category;
@@ -32,7 +31,6 @@
import org.apache.geode.test.junit.rules.JarFileRule;
import org.apache.geode.test.junit.rules.LocatorStarterRule;
-@Ignore("GEODE-4011 - test is polluting the environment")
@Category(DistributedTest.class)
public class ConcurrentDeployDUnitTest {
diff --git
a/geode-core/src/test/java/org/apache/geode/test/junit/rules/GfshCommandRule.java
b/geode-core/src/test/java/org/apache/geode/test/junit/rules/GfshCommandRule.java
index a3d448aa8e..48e99872a4 100644
---
a/geode-core/src/test/java/org/apache/geode/test/junit/rules/GfshCommandRule.java
+++
b/geode-core/src/test/java/org/apache/geode/test/junit/rules/GfshCommandRule.java
@@ -29,6 +29,7 @@
import org.apache.geode.management.cli.Result;
import org.apache.geode.management.internal.cli.HeadlessGfsh;
+import org.apache.geode.management.internal.cli.LogWrapper;
import org.apache.geode.management.internal.cli.i18n.CliStrings;
import org.apache.geode.management.internal.cli.result.CommandResult;
import org.apache.geode.management.internal.cli.shell.Gfsh;
@@ -95,6 +96,7 @@ public GfshCommandRule(Supplier<Integer> portSupplier,
PortType portType) {
@Override
protected void before(Description description) throws Throwable {
+ LogWrapper.close();
workingDir = temporaryFolder.newFolder("gfsh_files");
this.gfsh = new HeadlessGfsh(getClass().getName(), 30,
workingDir.getAbsolutePath());
ignoredException =
@@ -207,6 +209,7 @@ public void close() throws Exception {
}
gfsh.executeCommand("exit");
gfsh.terminate();
+ LogWrapper.close();
gfsh = null;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ConcurrentDeployDUnitTest is polluting test VMs
> -----------------------------------------------
>
> Key: GEODE-4011
> URL: https://issues.apache.org/jira/browse/GEODE-4011
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Jens Deppe
> Assignee: Jens Deppe
>
> This test launches gfsh from within 3 separate VMs. gfsh does some logger
> manipulation which results in stdout being redirected. Subsequent tests then
> may fail if they produce 'scary' suspect messages in the logs.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
