[
https://issues.apache.org/jira/browse/GEODE-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271913#comment-16271913
]
ASF GitHub Bot commented on GEODE-4029:
---------------------------------------
PurelyApplied commented on a change in pull request #1103: GEODE-4029: Deployed
jars may not be correct when multiple locators a…
URL: https://github.com/apache/geode/pull/1103#discussion_r153957783
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterConfigurationService.java
##########
@@ -352,6 +358,20 @@ public boolean removeJars(final String[] jarNames,
String[] groups) {
if (configuration == null) {
break;
}
+
+ for (String jarRemoved : jarNames) {
+ File jar = this.getPathToJarOnThisLocator(group,
jarRemoved).toFile();
+ if (jar.exists()) {
+ try {
+ FileUtils.forceDelete(jar);
+ } catch (IOException e) {
+ logger.error(
+ "Exception occurred while attempting to delete a jar from
the filesystem: {}",
+ jarRemoved, e);
+ }
Review comment:
Is it safe for this exception to be swallowed? I'll admit I'm shaky on how
the classloader works, but is there a risk that the jar could still get picked
up if it remains on the classpath? Or does the cluster config remove that
worry?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Deployed jars may not be correct when multiple locators are in use
> ------------------------------------------------------------------
>
> Key: GEODE-4029
> URL: https://issues.apache.org/jira/browse/GEODE-4029
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Jens Deppe
> Assignee: Jens Deppe
>
> When we have more than one locator, if a jar is re-deployed it will not be
> propagated correctly to the 'remote' locators. i.e. the locators which are
> not directly executing the 'deploy' command.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
