[
https://issues.apache.org/jira/browse/GEODE-3751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273157#comment-16273157
]
ASF GitHub Bot commented on GEODE-3751:
---------------------------------------
pivotal-jbarrett closed pull request #161: GEODE-3751: Removing an extraneous
change
URL: https://github.com/apache/geode-native/pull/161
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/clicache/src/impl/CacheWriter.hpp
b/clicache/src/impl/CacheWriter.hpp
index 12edaa1f..e5f238ab 100644
--- a/clicache/src/impl/CacheWriter.hpp
+++ b/clicache/src/impl/CacheWriter.hpp
@@ -76,8 +76,8 @@ namespace Apache
RegionEvent<TKey, TValue> gevent(ev->GetNative());
return m_writer->BeforeRegionDestroy(%gevent);
}
-
- virtual void Close(IRegion<Object^, Object^>^ region) override
+
+ virtual void Close(Apache::Geode::Client::Region<Object^, Object^>^
region) override
{
m_writer->Close((IRegion<TKey, TValue>^) region);
}
diff --git a/clicache/src/impl/ManagedCacheWriter.cpp
b/clicache/src/impl/ManagedCacheWriter.cpp
index bd495584..8489c0f2 100644
--- a/clicache/src/impl/ManagedCacheWriter.cpp
+++ b/clicache/src/impl/ManagedCacheWriter.cpp
@@ -297,7 +297,7 @@ namespace apache
void ManagedCacheWriterGeneric::close(const std::shared_ptr<Region>& rp)
{
try {
- IRegion<Object^, Object^>^ mregion =
Apache::Geode::Client::Region<Object^, Object^>::Create(rp);
+ auto mregion = Apache::Geode::Client::Region<Object^,
Object^>::Create(rp);
m_managedptr->Close(mregion);
}
catch (Apache::Geode::Client::GeodeException^ ex) {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor: ClientProtocolService, ClientStreamProcessor
> ------------------------------------------------------
>
> Key: GEODE-3751
> URL: https://issues.apache.org/jira/browse/GEODE-3751
> Project: Geode
> Issue Type: Improvement
> Components: client/server
> Reporter: Galen O'Sullivan
> Assignee: Galen O'Sullivan
> Fix For: 1.3.0
>
>
> The protobuf protocol logic is currently partly in
> {{GenericProtocolServerConnection}}, but authentication shouldn't really be
> assumed if it's a generic connection. Refactoring to a single service, with a
> pipeline that holds handshake/auth/message processing state, will allow us to
> improve authentication/authorization as well as add a handshake with much
> less headache.
> This is blocking GEODE-3705 and GEODE-3739.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
