[
https://issues.apache.org/jira/browse/GEODE-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275153#comment-16275153
]
ASF GitHub Bot commented on GEODE-3788:
---------------------------------------
jinmeiliao closed pull request #1107: GEODE-3788: add availability indicator
for alter aeq command
URL: https://github.com/apache/geode/pull/1107
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CommandAvailabilityIndicator.java
b/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CommandAvailabilityIndicator.java
index accfbe3c30..cfdeaa592e 100644
---
a/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CommandAvailabilityIndicator.java
+++
b/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CommandAvailabilityIndicator.java
@@ -49,7 +49,7 @@
CliStrings.CREATE_GATEWAYRECEIVER, CliStrings.START_GATEWAYRECEIVER,
CliStrings.STOP_GATEWAYRECEIVER, CliStrings.LIST_GATEWAY,
CliStrings.STATUS_GATEWAYSENDER,
CliStrings.STATUS_GATEWAYRECEIVER, CliStrings.LOAD_BALANCE_GATEWAYSENDER,
- CliStrings.DESTROY_GATEWAYSENDER})
+ CliStrings.DESTROY_GATEWAYSENDER,
AlterAsyncEventQueueCommand.COMMAND_NAME})
public boolean clientCommandsAvailable() {
Gfsh gfsh = Gfsh.getCurrentInstance();
diff --git
a/geode-core/src/main/java/org/apache/geode/management/internal/cli/help/Helper.java
b/geode-core/src/main/java/org/apache/geode/management/internal/cli/help/Helper.java
index 917f3e4961..aaf743e368 100644
---
a/geode-core/src/main/java/org/apache/geode/management/internal/cli/help/Helper.java
+++
b/geode-core/src/main/java/org/apache/geode/management/internal/cli/help/Helper.java
@@ -187,6 +187,10 @@ boolean isAvailable(String command) {
}
}
+ public boolean hasAvailabilityIndicator(String command) {
+ return availabilityIndicators.get(command) != null;
+ }
+
HelpBlock getHelp() {
HelpBlock root = new HelpBlock();
commands.keySet().stream().sorted().map(commands::get).forEach(method -> {
diff --git
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CommandAvailabilityIndicatorTest.java
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CommandAvailabilityIndicatorTest.java
new file mode 100644
index 0000000000..f94a94f727
--- /dev/null
+++
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CommandAvailabilityIndicatorTest.java
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.lang.reflect.Method;
+import java.util.List;
+
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.springframework.shell.core.CommandMarker;
+import org.springframework.shell.core.annotation.CliCommand;
+
+import org.apache.geode.management.cli.CliMetaData;
+import org.apache.geode.management.internal.cli.CommandManager;
+import org.apache.geode.test.junit.categories.UnitTest;
+
+
+@Category(UnitTest.class)
+public class CommandAvailabilityIndicatorTest {
+
+ @Test
+ public void allOnlineCommandsHaveAvailabilityIndicator() throws Exception {
+ CommandManager manager = new CommandManager();
+ List<CommandMarker> commandMarkers = manager.getCommandMarkers();
+
+ for (CommandMarker commandMarker : commandMarkers) {
+ // ignore all the other commands beside GfshCommand
+ if (!GfshCommand.class.isAssignableFrom(commandMarker.getClass())) {
+ continue;
+ }
+
+ GfshCommand gfshCommand = (GfshCommand) commandMarker;
+ for (Method method : commandMarker.getClass().getMethods()) {
+ CliCommand cliCommand = method.getAnnotation(CliCommand.class);
+ CliMetaData cliMetaData = method.getAnnotation(CliMetaData.class);
+
+ // all the online commands have availability indicator defined in the
commandManager
+ if (cliMetaData != null && !cliMetaData.shellOnly()) {
+
assertThat(manager.getHelper().hasAvailabilityIndicator(cliCommand.value()[0]))
+ .describedAs(cliCommand.value()[0] + " has no availability
indicator defined. "
+ + "Please add the command in the
CommandAvailabilityIndicator")
+ .isTrue();
+ }
+ }
+ }
+ }
+
+
+
+}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> alter async event queue attributes
> ----------------------------------
>
> Key: GEODE-3788
> URL: https://issues.apache.org/jira/browse/GEODE-3788
> Project: Geode
> Issue Type: Sub-task
> Components: docs, gfsh
> Reporter: Swapnil Bawaskar
> Fix For: 1.4.0
>
>
> We should add a new {{alter async-event-queue}} gfsh command that will allow
> users to change the following attributes on the AsyncEventQueue:
> - batch size
> - batch time interval
> - maximum queue memory
> Attributes changed with this command should only be reflected in cluster
> configuration. We will require users to do a rolling re-start of the servers
> for the new settings to take effect.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
