[
https://issues.apache.org/jira/browse/GEODE-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277242#comment-16277242
]
ASF GitHub Bot commented on GEODE-4042:
---------------------------------------
nabarunnag closed pull request #1114: GEODE-4042: Cargo tests will use
java.io.tmpdir if possible
URL: https://github.com/apache/geode/pull/1114
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/geode-assembly/src/test/java/org/apache/geode/session/tests/ContainerInstall.java
b/geode-assembly/src/test/java/org/apache/geode/session/tests/ContainerInstall.java
index 5064c22512..4409d17687 100644
---
a/geode-assembly/src/test/java/org/apache/geode/session/tests/ContainerInstall.java
+++
b/geode-assembly/src/test/java/org/apache/geode/session/tests/ContainerInstall.java
@@ -63,10 +63,11 @@
private final String MODULE_PATH;
private final String WAR_FILE_PATH;
+ public static final String TMP_DIR = System.getProperty("java.io.tmpdir",
"/tmp");
public static final String GEODE_BUILD_HOME = System.getenv("GEODE_HOME");
- public static final String DEFAULT_INSTALL_DIR = "/tmp/cargo_containers/";
+ public static final String DEFAULT_INSTALL_DIR = TMP_DIR +
"/cargo_containers/";
protected static final String DEFAULT_MODULE_LOCATION = GEODE_BUILD_HOME +
"/tools/Modules/";
- public static final String DEFAULT_MODULE_EXTRACTION_DIR =
"/tmp/cargo_modules/";
+ public static final String DEFAULT_MODULE_EXTRACTION_DIR = TMP_DIR +
"/cargo_modules/";
/**
* Represents the type of connection used in this installation
@@ -137,7 +138,8 @@ public ContainerInstall(String installDir, String
downloadURL, ConnectionType co
logger.info("Installing container from URL " + downloadURL);
// Optional step to install the container from a URL pointing to its
distribution
- Installer installer = new ZipURLInstaller(new URL(downloadURL),
"/tmp/downloads", installDir);
+ Installer installer =
+ new ZipURLInstaller(new URL(downloadURL), TMP_DIR + "/downloads",
installDir);
installer.install();
// Set install home
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Cargo tests for Jetty and Tomcat should use java.io.tmpdir instead of
> hardcoding to /tmp
> ----------------------------------------------------------------------------------------
>
> Key: GEODE-4042
> URL: https://issues.apache.org/jira/browse/GEODE-4042
> Project: Geode
> Issue Type: Bug
> Components: http session
> Reporter: Jason Huynh
> Assignee: Jason Huynh
>
> Currently the Cargo Tests for the session state module are hard coded to run
> off of /tmp. Instead it should probably be pointed towards using
> java.io.tmpdir.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
