[
https://issues.apache.org/jira/browse/GEODE-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282076#comment-16282076
]
ASF GitHub Bot commented on GEODE-3288:
---------------------------------------
dgkimura commented on a change in pull request #165: GEODE-3288: Converts
CacheableString to std::string.
URL: https://github.com/apache/geode-native/pull/165#discussion_r155560273
##########
File path: cppcache/src/PdxInstanceFactoryImpl.cpp
##########
@@ -139,14 +139,23 @@ std::shared_ptr<PdxInstanceFactory>
PdxInstanceFactoryImpl::writeWideString(
return shared_from_this();
}
std::shared_ptr<PdxInstanceFactory> PdxInstanceFactoryImpl::writeString(
- const std::string& fieldName, const char* value) {
+ const std::string& fieldName, const std::string& value) {
isFieldAdded(fieldName);
m_pdxType->addVariableLengthTypeField(fieldName, "string",
PdxFieldTypes::STRING);
auto cacheableObject = CacheableString::create(value);
m_FieldVsValues.emplace(fieldName, cacheableObject);
return shared_from_this();
}
+std::shared_ptr<PdxInstanceFactory> PdxInstanceFactoryImpl::writeString(
Review comment:
This logic looks almost duplicated. Again, if universal ref and
std::forward work then maybe we can consolidate the logic to one place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace char* with std::string
> ------------------------------
>
> Key: GEODE-3288
> URL: https://issues.apache.org/jira/browse/GEODE-3288
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Ernest Burghardt
>
> In all public API headers
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
