[
https://issues.apache.org/jira/browse/GEODE-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282275#comment-16282275
]
ASF GitHub Bot commented on GEODE-3288:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #165: GEODE-3288:
Converts CacheableString to std::string.
URL: https://github.com/apache/geode-native/pull/165#discussion_r155602320
##########
File path: cppcache/include/geode/DataInput.hpp
##########
@@ -341,6 +339,11 @@ class CPPCACHE_EXPORT DataInput {
str[length] = '\0';
}
+ template <class CharT, class... Tail>
+ inline void readAscii(std::basic_string<CharT, Tail...>& value) {
Review comment:
I use that to enforce that it must be a `basic_string` type but it isn't
necessary. Either way the compiler will fail, either that it can't match a
template or it can't find a string method on some random provided type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace char* with std::string
> ------------------------------
>
> Key: GEODE-3288
> URL: https://issues.apache.org/jira/browse/GEODE-3288
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Ernest Burghardt
>
> In all public API headers
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
