[
https://issues.apache.org/jira/browse/GEODE-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282806#comment-16282806
]
ASF GitHub Bot commented on GEODE-4068:
---------------------------------------
upthewaterspout closed pull request #1142: GEODE-4068: Removing RemoveAll from
.proto files
URL: https://github.com/apache/geode/pull/1142
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/geode-protobuf-messages/src/main/proto/v1/clientProtocol.proto
b/geode-protobuf-messages/src/main/proto/v1/clientProtocol.proto
index 820c03d740..992c8d697d 100644
--- a/geode-protobuf-messages/src/main/proto/v1/clientProtocol.proto
+++ b/geode-protobuf-messages/src/main/proto/v1/clientProtocol.proto
@@ -41,7 +41,6 @@ message Request {
PutAllRequest putAllRequest = 12;
GetAllRequest getAllRequest = 13;
RemoveRequest removeRequest = 14;
- RemoveAllRequest removeAllRequest = 15;
GetAvailableServersRequest getAvailableServersRequest = 40;
GetRegionNamesRequest getRegionNamesRequest = 41;
@@ -59,7 +58,6 @@ message Response {
PutAllResponse putAllResponse = 12;
GetAllResponse getAllResponse = 13;
RemoveResponse removeResponse = 14;
- RemoveAllResponse removeAllResponse = 15;
GetAvailableServersResponse getAvailableServersResponse = 40;
GetRegionNamesResponse getRegionNamesResponse = 41;
diff --git a/geode-protobuf-messages/src/main/proto/v1/region_API.proto
b/geode-protobuf-messages/src/main/proto/v1/region_API.proto
index 4313be11af..b68eb5db37 100644
--- a/geode-protobuf-messages/src/main/proto/v1/region_API.proto
+++ b/geode-protobuf-messages/src/main/proto/v1/region_API.proto
@@ -69,15 +69,6 @@ message RemoveRequest {
message RemoveResponse {
}
-message RemoveAllRequest {
- string regionName = 1;
- repeated EncodedValue key = 2;
-}
-
-message RemoveAllResponse {
- bool success = 1;
-}
-
message GetRegionNamesRequest {
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove unimplemented RemoveAllRequest/Response from region_api.proto
> --------------------------------------------------------------------
>
> Key: GEODE-4068
> URL: https://issues.apache.org/jira/browse/GEODE-4068
> Project: Geode
> Issue Type: Bug
> Components: client/server
> Reporter: Dan Smith
> Fix For: 1.4.0
>
>
> The new protocol messages include a RemoveAllRequest and RemoveAllResponse.
> However, RemoveAllRequest is not handled on the server. We should remove this
> unimplemented message.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
