[
https://issues.apache.org/jira/browse/GEODE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
nabarun updated GEODE-4072:
---------------------------
Description:
*+Issue+*
{code:title=AckReaderThread.java}
if (connection != null) {
Connection conn = connection;
shutDownAckReaderConnection();
if (!conn.isDestroyed()) {
conn.destroy();
sender.getProxy().returnConnection(conn);
}
}
{code}
The global connection variable may be set to null before it is assigned to the
local variable, resulting in NPE.
*Solution*:
--set the local variable to the connection variable and use that local variable
for null checks.
was:
*+Issue+*
{code:title=AckReaderThread.java}
if (connection != null) {
Connection conn = connection;
shutDownAckReaderConnection();
if (!conn.isDestroyed()) {
conn.destroy();
sender.getProxy().returnConnection(conn);
}
}
{code}
The global connection variable may be set to null before it is assigned to the
local variable, resulting in NPE.
*Solution*:
--set the local variable before the tests are being done.
> Race condition in AckReaderThread.shutdown
> -------------------------------------------
>
> Key: GEODE-4072
> URL: https://issues.apache.org/jira/browse/GEODE-4072
> Project: Geode
> Issue Type: Bug
> Components: wan
> Reporter: nabarun
> Assignee: nabarun
>
> *+Issue+*
> {code:title=AckReaderThread.java}
> if (connection != null) {
> Connection conn = connection;
> shutDownAckReaderConnection();
> if (!conn.isDestroyed()) {
> conn.destroy();
> sender.getProxy().returnConnection(conn);
> }
> }
> {code}
> The global connection variable may be set to null before it is assigned to
> the local variable, resulting in NPE.
> *Solution*:
> --set the local variable to the connection variable and use that local
> variable for null checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
