[
https://issues.apache.org/jira/browse/GEODE-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288360#comment-16288360
]
ASF GitHub Bot commented on GEODE-4082:
---------------------------------------
dgkimura commented on a change in pull request #168: GEODE-4082: Changes
objectSize to return size_t.
URL: https://github.com/apache/geode-native/pull/168#discussion_r156508792
##########
File path: tests/cpp/security/Security.cpp
##########
@@ -755,7 +755,7 @@ std::shared_ptr<Region> Security::getRegionPtr(const char
*reg) {
try {
if (name.empty()) { // just get a random root region
auto rootRegionVector = m_cache->rootRegions();
- int32_t size = rootRegionVector.size();
+ int32_t size = static_cast<int32_t>(rootRegionVector.size());
Review comment:
Could this be `auto` and do we need to `static_cast`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Serializable::objectSize should return size_t
> ---------------------------------------------
>
> Key: GEODE-4082
> URL: https://issues.apache.org/jira/browse/GEODE-4082
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Jacob S. Barrett
> Assignee: Jacob S. Barrett
>
> For consistency with C++11 object sizes returned from
> {Serializable::objectSize} should be of type {size_t}. For consistency and
> counting of larger collections .NET interface {IGeodeSerializable.ObjectSize}
> should return {System::UInt64}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
