[
https://issues.apache.org/jira/browse/GEODE-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289989#comment-16289989
]
ASF GitHub Bot commented on GEODE-4084:
---------------------------------------
galen-pivotal commented on a change in pull request #1155: GEODE-4084 rename
handshake.proto
URL: https://github.com/apache/geode/pull/1155#discussion_r156796177
##########
File path: geode-protobuf-messages/src/main/proto/protocolVersion.proto
##########
@@ -25,13 +25,13 @@ enum MinorVersions {
CURRENT_MINOR_VERSION = 1; // Protobuf implementation at initial release
}
-message NewConnectionHandshake {
Review comment:
Do you think it would be worthwhile to add a comment saying that we will
need both fields to be populated and nonzero for the handshake to work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> rename handshake.proto
> ----------------------
>
> Key: GEODE-4084
> URL: https://issues.apache.org/jira/browse/GEODE-4084
> Project: Geode
> Issue Type: Task
> Components: client/server
> Reporter: Bruce Schuchardt
> Assignee: Bruce Schuchardt
>
> We envision having another handshake between client & server in the future.
> Since the current Handshake is going to remain fixed in content for the
> foreseeable future we should rename it to something more like
> "NewConnectionVersion" or something. Then we can introduce a Handshake with
> more information exchange in the future.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
